Adding transparent colours on nft format #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hmmm the main issue I have really is that NFT is something that's already pretty widely used and wasn't even created by any of us; so nothing would really change. Worth noting though that (if memory serves correct) you can just use a space character for transparent foreground. |
Author
|
You're right but having transparent background and using a space character would mean "don't modify that pixel" and that's what I need. Now I've got a question, what if the color specified isn't a valid hex... Should the color be set to transparent, should the program error or should it use the last color that was set to text/background? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding what was mentioned on issue #69